<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
p.msochpdefault, li.msochpdefault, div.msochpdefault
{mso-style-name:msochpdefault;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:10.0pt;
font-family:"Calibri","sans-serif";}
span.emailstyle18
{mso-style-name:emailstyle18;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoPlainText">Gavin, we really appreciate the time you put into reviewing and improving the patches.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">I have done some more testing with focus on the EoE part and in one setup I have now observed that the EtherCAT-EoE thread can end up in an forever uninterruptable sleep. I can reproduce this in both the patch serie from 20160502/20160610
and in the newest patch serie from 20160613. I will investigate this further.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">A few comments to below patches:<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Patch 0037:<o:p></o:p></p>
<p class="MsoPlainText">The versioning is a bit tricky and to be safe we have to use version 3.17 where the detect_deadlock argument for sure is dropped. If using the RT kernel patch, the argument must be dropped from 3.14.34-rt32, but it is not possible to
do a check on the rt32 version part that is just given by a tag. I will update the patch to use version 3.17 and maybe also allow the detect_deadlock argument to be dropped via configure.ac so we can support the Linux Real time versions from 3.14.34-rt32.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Patch 0032:<o:p></o:p></p>
<p class="MsoPlainText">Yes, now I recall that we discussed this about a year ago and it is actually the commit message that is a bit wrong as we do actually enter INIT + ERROR after the Master has requested PREOP. I will update the commit message to make this
a bit more clear.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Patch 0034:<o:p></o:p></p>
<p class="MsoPlainText">Yes, I should have known that this of cause is unnecessary for the read part (as I have previously worked with the SII cache part). I will update the patch and remove this part again.<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Thanks,<o:p></o:p></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">Knud<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Gavin Lambert [<a href="mailto:gavinl@compacsort.com">mailto:gavinl@compacsort.com</a>]
<br>
<b>Sent:</b> 13. juni 2016 08:34<br>
<b>To:</b> Knud Baastrup; Florian Pose; 'David Page'<br>
<b>Cc:</b> <a href="mailto:etherlab-dev@etherlab.org">etherlab-dev@etherlab.org</a><br>
<b>Subject:</b> RE: [PATCH] Default branch patchset re-applied on 5a70ff<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US">Ok, I’ve looked through the new patches now. Attached is my refresh of them. Mostly it’s just inclusion of a series file and cleaning up the commit messages to be HG-safe (HG doesn’t
quite like some of the things that git adds, such as diffstats and a few other artefacts). Other changes include:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Adopted the filenames from Knud’s set.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Replaced <b>0037-Breaking-change-rt_mutx_lock_interruptible-calls-for.patch</b> with a version that isn’t a breaking change (assuming the version numbers in the commit message were correct; I haven’t
verified this). This could probably be folded into patch 0004, but I left it separate for clarity.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Added <b>0040-rescan-check-revision.patch</b>. This modifies patch 0013 in four ways:<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">1.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">The SII cache-and-reuse behaviour can be disabled via –disable-sii-cache at configure time, rather than requiring modifying a header file.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">2.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">The revision number is also verified before using the cached version (this resolves some issues when the device firmware is upgraded).<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">3.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">If both the alias and serial are read as 0, it will no longer bother reading the vendor/product/revision, as it is now known that the SII is not in the cache.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">4.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Several similar states are consolidated into one.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Added <b>0041-load-sii-from-file.patch</b>, from Graeme Foot’s recent patch; but I’ve made the following modifications:<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">1.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">The functionality is disabled by default.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">2.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">At configure time, you can use –enable-sii-override to activate it, using the standard udev/hotplug lookup process.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">3.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">At configure time, you can use –enable-sii-override=/lib/firmware (or another path) to activate it using a direct loading method.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">4.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">A bug where it would fail to load 6 words of the SII when
<b>not</b> loading from a file has been corrected.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">5.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Several places where it exited the state prematurely have been corrected.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="margin-left:72.0pt;text-indent:-18.0pt"><span lang="EN-NZ" style="mso-fareast-language:EN-US">6.</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">It will cooperate as expected with patch 0013, although note that it’s not as efficient as it could be (it will reload some of the values that patch 0013 already read when checking the SII cache;
but trying to improve this would make the code really awkward).<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">Added <b>0042-load-sii-from-file-async.patch</b>, which makes the above firmware loading asynchronous so it doesn’t block the master thread, since that makes me uncomfortable. Again this could be
folded into the prior patch but I left it separate so that the differences are apparent and easier to review. I’m also pondering whether the firmware loading stuff (or perhaps even the whole SII loading stuff including the reuse cache) should be broken out
into a separate sub-FSM file. It’s not really complicated but it’s a bit wordy, particularly with the direct-loading support included. Open to suggestions here.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><span lang="EN-NZ" style="mso-fareast-language:EN-US">(Note these additions aren’t breaking changes, but I didn’t want to renumber the patches just because of that. They should be able to apply prior to the breaking change patches if you want to try
it that way.)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US">Some other thoughts about the new patches (I haven’t modified anything for these):<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><b><span lang="EN-NZ" style="mso-fareast-language:EN-US">0032-Correction-to-Clear-slave-mailboxes-after-a-re-scan.patch</span></b><span lang="EN-NZ" style="mso-fareast-language:EN-US">:<br>
As previously mentioned, the stated circumstances should never happen, as a slave is not permitted to refuse to enter INIT. But the patch itself is probably harmless.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span lang="EN-NZ" style="font-family:Symbol;mso-fareast-language:EN-US">·</span><span lang="EN-NZ" style="font-size:7.0pt;font-family:"Times New Roman","serif";mso-fareast-language:EN-US">
</span><b><span lang="EN-NZ" style="mso-fareast-language:EN-US">0034-Tool-Withdraw-EEPROM-control-for-SII-read-write.patch</span></b><span lang="EN-NZ" style="mso-fareast-language:EN-US">:<br>
This seems like it should have some conditioning on EC_SII_ASSIGN, since unless that is enabled the SII should always be assigned to ECAT anyway. Additionally the changes to CommandSiiRead.cpp are completely unnecessary (or don’t work as intended), as this
doesn’t access the device – it reads the SII contents as cached during scanning (even before patch 0013 happened). I also wonder if perhaps the mode switch on writing should be done in the state machines instead, so that it can be switched to ECAT only just
prior to the write and then restored afterwards.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="mso-fareast-language:EN-US">Please let me know if you have any questions or suggestions, or if there’s a different way I can present these that would help them get merged faster.
</span><span lang="EN-NZ" style="font-family:Wingdings;mso-fareast-language:EN-US">J</span><span lang="EN-NZ" style="mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-NZ" style="color:#1F497D;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Gavin Lambert
<br>
<b>Sent:</b> Sunday, 12 June 2016 01:25<br>
<b>To:</b> Knud Baastrup <</span><a href="mailto:kba@deif.com"><span lang="EN-US">kba@deif.com</span></a><span lang="EN-US">>; Florian Pose <</span><a href="mailto:fp@igh.de"><span lang="EN-US">fp@igh.de</span></a><span lang="EN-US">>; 'David Page' <</span><a href="mailto:dave.page@gleeble.com"><span lang="EN-US">dave.page@gleeble.com</span></a><span lang="EN-US">><br>
<b>Subject:</b> Re: [PATCH] Default branch patchset re-applied on 5a70ff<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-NZ"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">Heh, looks like you beat me to it - I was in the process of rebasing to the same point (along with some additional tweaks - in particular I'm testing the loadable SII
patch Graeme provided a few weeks ago. Sadly it has some bugs but I think I have it nearly ready).<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">I'm away from my test setup ATM but I'll have a look at these next week.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p> </o:p></span></p>
</div>
<div id="composer_signature">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Times New Roman","serif";color:#575757">Sent from my Samsung Galaxy smartphone.<o:p></o:p></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">-------- Original message --------<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">From: Knud Baastrup <</span><a href="mailto:kba@deif.com"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">kba@deif.com</span></a><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">>
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">Date: 11/06/2016 00:55 (GMT+12:00)
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">To: Florian Pose <</span><a href="mailto:fp@igh.de"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">fp@igh.de</span></a><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">>,
'David Page' <</span><a href="mailto:dave.page@gleeble.com"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">dave.page@gleeble.com</span></a><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">>, Gavin Lambert <</span><a href="mailto:gavin.lambert@compacsort.com"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">gavin.lambert@compacsort.com</span></a><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">>
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">Cc:
</span><a href="mailto:etherlab-dev@etherlab.org"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">etherlab-dev@etherlab.org</span></a><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif"">Subject: [PATCH] Default branch patchset re-applied on 5a70ff
<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman","serif""><o:p> </o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">I have re-applied the patch serie from Gavin Lambert on the latest commit on default branch (5a70ff from 2016-05-04) and as well added some additional (minor) patches (see the short explanation in the patch it-selves). I have placed the
“Breaking change” patches in the end and done some extensive testing including all patches up to and including patch 0037. The tests have involved a lot of EoE traffic tests that all passed successfully.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">The patches are created with GIT (and named according to the commit message) but I believe they can easily be applied on HG as well. I have as well cleaned the patches for all white-space related issues.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">The patch serie is quite long and a bit cumbersome to maintain so I hope we soon can get more of them included on the default branch.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0001-Distributed-Clock-fixes-and-helpers.patch (same as 0001-graemef-dc_fixes_and_helpers.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0002-Distributed-Clock-fixes-from-Jun-Yuan.patch (same as 0002-junyuan-dc_sync_issues.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0003-Do-not-reuse-the-index-of-a-pending-datagram.patch (same as 0003-frank-index-reuse.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0004-If-enable-rtmutex-use-rtmutexes-instead-of-semaphore.patch (same as 0004-gavinl-Semaphores-replaced-with-mutexes.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0005-Support-for-multiple-mailbox-protocols.patch (same as 0005-knud-Support-for-multiple-mailbox-protocols.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0006-Await-SDO-dictionary-to-be-fetched.patch (same as 0006-knud-Await-SDO-dictionary-to-be-fetched.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0007-Protection-of-external-datagram-queue.patch (same as 0007-knud-Protection-of-external-datagram-queue.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0008-Clear-slave-mailboxes-after-a-re-scan.patch (same as 0008-knud-Clear-slave-mailboxes-after-a-re-scan.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0009-Skip-output-statistics-during-re-scan.patch (same as 0009-knud-Skip-output-statistics-during-re-scan.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0010-Sdo-directory-now-only-fetched-on-request.patch (same as 0010-knud-Sdo-directory-now-only-fetched-on-request.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0011-Master-locks-to-avoid-corrupted-datagram-queue.patch (same as 0011-knud-Master-locks-to-avoid-corrupted-datagram-queue.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0012-Ignore-mailbox-settings-if-corrupted-sii-file.patch (same as 0012-knud-Ignore-mailbox-settings-if-corrupted-sii-file.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0013-Improved-EtherCAT-rescan-performance.patch (same as 0013-knud-Improved-EtherCAT-rescan-performance.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0014-Fix-NOHZ-local_softirq_pending-08-warning.patch (same as 0016-knud-Fix-NOHZ-local_softirq_pending-08-warning.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0015-EoE-processing-is-now-only-allowed-in-state-PREOP.patch (same as 0017-knud-EoE-processing-is-now-only-allowed-in-state-PREOP-SA.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0016-Prevent-abandoning-the-mailbox-state-machines-early-.patch (same as 0101-gavinl-mbox-finish-sm.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0017-Make-busy-logging-a-little-less-irritating.patch (same as 0102-gavinl-sdo_logging_verbosity.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0018-Clear-configuration-on-deactivate-even-if-not-activa.patch (same as 0103-gavinl-clear_on_deactivate.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0019-After-a-comms-interruption-allow-SAFEOP-OP-directly-.patch (same as 0104-gavinl-quick_op_watchdog.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0020-Adding-some-more-state-to-avoid-calling-the-more-exp.patch (same as 0105-gavinl-more_state.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0021-Detect-bypassed-ports-timestamp-not-updated.patch (same as 0106-gavinl-topology_bypass.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0022-Calculate-most-likely-upstream-port-for-each-slave.patch (same as 0107-gavinl-topology_upstream.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0023-Print-redundancy-device-name-with-ring-positions-as-.patch (same as0108-gavinl-redundant_device.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0024-RX-does-not-reset-watchdog-breaks-redundancy.patch (same as 0109-gavinl-e1000e_watchdog.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0025-Add-command-to-request-hardware-reboot-for-slaves-th.patch (same as 0110-gavinl-reboot.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0026-Add-register-read-write-support.patch (same as 0111-gavinl-reg_readwrite.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0027-Display-more-info-about-the-register-requests-in-pro.patch (same as 0112-gavinl-reg_req_info.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0028-Support-SDO-upload-via-complete-access.patch (same as 0113-gavinl-sdo_complete_upload.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0029-Disable-DC-SYNC-before-updating-a-running-slave-s-sy.patch (same as 0116-gavinl-dc-sync-vs-sys-time.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0030-Use-call-back-functions.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0031-Added-newline-to-syslog-message-MAC-address-derived.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0032-Correction-to-Clear-slave-mailboxes-after-a-re-scan.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0033-Corrected-debug-level-for-Aborting-dictionary.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0034-Tool-Withdraw-EEPROM-control-for-SII-read-write.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0035-Add-support-for-bringup-up-network-interface-when-st.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0036-Reduced-printing-to-avoid-syslog-spam.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0037-Breaking-change-rt_mutx_lock_interruptible-calls-for.patch (NEW)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0038-Breaking-change-require-data-size-to-be-specified-in.patch (same as 0114-gavinl-sdo_write_size.patch)<o:p></o:p></p>
<p class="MsoListParagraph" style="text-indent:-18.0pt"><span style="font-family:Symbol">·</span><span style="font-size:7.0pt;font-family:"Times New Roman","serif"">
</span>0039-Breaking-change-Support-for-SDO-complete-access-in-e.patch (same as 0115-gavinl-sdo_async_complete.patch)<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:6.0pt;font-family:"Arial","sans-serif";color:black"><br>
</span><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif"">Venlig hilsen / Best regards,
</span><o:p></o:p></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif";color:black">Knud Baastrup
<br>
</span></b><i><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif";color:black">DEIF Wind Power Technology</span></i><span lang="EN-US" style="font-size:10.0pt;font-family:"Arial","sans-serif""><br>
<i><span style="color:black">SW Developer</span></i></span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">Direct.: +45 9614 8458</span><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:navy"><br>
</span><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">E-mail:
</span><a href="mailto:kba@deif.com"><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#0563C1">kba@deif.com</span></a><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">---------------------------------------------------------------</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">DEIF A/S<br>
Frisenborgvej 33<br>
DK-7800 Skive<br>
</span><span lang="EN-US" style="font-size:2.0pt;font-family:"Arial","sans-serif";color:#4A575E"><br>
</span><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">Tel.: +45 9614 9614</span><span lang="EN-US">
<br>
</span><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif";color:#4A575E">Fax: +45 9614 9615<br>
</span><span lang="EN-US" style="font-size:2.0pt;font-family:"Arial","sans-serif";color:#4A575E"><br>
</span><a href="http://www.deifwindpower.com/"><span lang="EN-US" style="font-size:7.5pt;font-family:"Arial","sans-serif"">www.deifwindpower.com</span></a><o:p></o:p></p>
<p class="MsoNormal"><i><span lang="EN-US" style="font-size:10.0pt;color:#2E75B6">“This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. Please notify the sender
immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this
information is strictly prohibited”</span></i><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>