[etherlab-dev] [PATCH] FoE omnibus patch

[Dave Page]

     Sorry about that, and thanks for catching the defect. I should have 
taken the time to understand why the time was non-monotonic in the first 
place.

         Best regards - Dave


On 2014-01-23 19:53, Gavin Lambert wrote:
> Quoth Dave Page:
>>       The attached patch against 51ad16e57f8f includes Gavin Lambert's
>> FoE patches as folows:
> [...]
>>       And includes a one-liner PacketNo read busy sequence patch as well
>> as a FoE spurious timeout patch.
> There's an error in the spurious timeout part of the patch.
>
> In ec_fsm_foe_state_ack_check, the patched code uses datagram->jiffies_received instead of fsm->datagram->jiffies_received.  The latter is the received packet, while the former is a "recyclable" packet intended for the outgoing request.
>
> (This is actually a regression from commit 8bb574, which fixed the bug a different way; so 51ad16 should have worked as-is, although I think I prefer use of "time_after" as it keeps the multiplies away.)
>
>
> I've attached a modified version of the omnibus patch which fixes that, plus some minor reformatting.  I've verified that the code compiles with the patch but not against slave hardware as yet.  (Also, my patch was against f8b779, but it should still apply cleanly to 51ad16 as that file hasn't been changed since then.)
>
>
> Florian, if you'd prefer that these patches be separated (either as a series or independent), let me know; I can do that pretty quickly.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dave_page.vcf
Type: text/x-vcard
Size: 313 bytes
Desc: not available
URL: <http://lists.etherlab.org/pipermail/etherlab-dev/attachments/20140123/58046659/attachment.vcf>